Repository navigation
fix(python): publish raw austin profiles as .txt, not .svg - #138
Merged
Merged
Conversation
austin had no case in GetFileExtension and fell through to the ".svg" default, so a raw memory profile shipped as agent-raw-<pid>-1.svg.gz. Consumers that choose a renderer by suffix drew the text as an image. The e2e check now asserts the .txt.gz name.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where raw Austin memory profiles were incorrectly given an .svg extension instead of .txt, causing rendering issues. It updates GetFileExtension to handle api.Austin correctly, adds corresponding unit tests, and updates the E2E test script to verify the file extension. There are no review comments to address.
blue4209211
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A raw austin (Python memory) profile is published as
agent-raw-<pid>-1.svg.gz, even though its content is plain text.GetFileExtensionhad no austin case, so it fell through to the.svgdefault. Consumers that pick a renderer by file suffix draw the text as a broken image.austin now shares the Bpf/Perf mapping: raw →
.txt, flamegraph →.svg.This commit was pushed to #137 after it had been merged, so it never reached
main.Type of change
Test plan
TestGetFileExtension_Austin: raw →.txt, flamegraph →.svg, and the full result file name ends in-<pid>-1.txt.test/e2e/python-austin.shnow also asserts that the published raw profile is*.txt.gz.Engineering detail
Local e2e: built
docker/python/Dockerfilefrom this branch and rantest/e2e/python-austin.shagainst it. All four targets passed, each published asagent-raw-1-1.txt.gz:Negative control: the same script against the image published from current
main(application-profiler-python:6116ac0) fails every target withraw profile published as /tmp/agent-raw-1-1.svg.gz, want *.txt.gz.Checklist
go build ./...andgo test ./...pass locally.svgto.txt, for austin raw output.