Repository navigation
chore(release): remove Homebrew tap publishing - #33
Merged
Merged
Conversation
Install and update through scripts/install.sh and nssh self reinstall only. Drop the homebrew-nssh release job and its TAP_GITHUB_TOKEN use, the README badge and brew install line, and the Homebrew prefix from FindBinary; /usr/local/bin stays for manual installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Homebrew is no longer an install channel. nssh is installed with
scripts/install.shand updated withnssh self reinstall, which both use GitHub releases.Implementation Notes
.github/workflows/build.yml: removed thehomebrew-nsshjob, which also removes the only use of theTAP_GITHUB_TOKENsecret. Tagged releases still build and upload the release archives and checksums.README.md: removed the Homebrew badge and thebrew installline, and added a sentence saying to update withnssh self reinstall.internal/cli/self/common.go:FindBinaryno longer checks/opt/homebrew/bin/nssh./usr/local/bin/nsshstays for manual installs.The
brew install agghint ininternal/cli/log/export.gostays. It's about installing the separateaggtool, not nssh.Verification
go build ./...andgo test ./internal/cli/self/pass.git grep -i 'homebrew\|TAP_GITHUB'finds nothing.