Repository navigation
fix(inventory): resolve NetBox credentials from command variables - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetBox inventory refresh fails when credentials are supplied by NETBOX_URL_CMD and NETBOX_TOKEN_CMD rather than exported values or ~/.env. Resolve the configured variable directly first, then its _CMD command, then the existing dotenv fallback.
Commands run through /bin/sh with a 10-second timeout and parent cancellation. Failed or empty commands stop the lookup without exposing command text, stdout, or stderr in errors. No credentials are persisted.
Validation: make container-test passed (dependency/format checks, vet, all tests, builds, lint, and four-platform cross-compilation). Added tests cover precedence, whitespace, dotenv fallback, empty output, sanitized failures, and cancellation. Updated the embedded configuration comments. CLI help and SSH credential delivery are unchanged.