fix(*): verb-first server actions, noun-first constructors - #234
Open
nteetor wants to merge 3 commits into
Open
Conversation
Rename modal_show()/modal_hide() to show_modal()/hide_modal(), file_upload_start()/file_upload_cancel() to start_file_upload()/ cancel_file_upload(), and update_menu_input() to update_menu(). modal_toggle() becomes modal_button(), modal_close() becomes modal_close_icon(), modal_dismiss() becomes modal_close_button() with label in place of text, and alert_button() becomes alert_close_icon(); the three close constructors pass ... on as button attributes. The file_upload readers now own the ?file_upload page with the two verbs joined by @Rdname. No deprecation shims. Bundles rebuilt for the file.ts comments that name the verbs. Co-Authored-By: Claude <[email protected]>
The function-naming capability records the noun-first constructor and verb-first action contract, the verb vocabulary, and the no-alias rule for renames. Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the OpenSpec change
rename-server-verbs(epic yonder-9dt), applying the naming rule from yonder-9vy: server-side actions are verb-first, UI constructors and readers are noun-first, following bslib's convention (rstudio/bslib#706). The collapse panel already followed it (#233); this brings the rest of the package in line.Breaking changes (no deprecation shims — the package is a reboot):
modal_show()/modal_hide()→show_modal()/hide_modal()file_upload_start()/file_upload_cancel()→start_file_upload()/cancel_file_upload(); the fourfile_upload_*()readers keep their names and now own the?file_uploadhelp page, with the two verbs joined by@rdnameupdate_menu_input()→update_menu()modal_toggle()→modal_button()(it is a trigger button, not an action)modal_close()→modal_close_icon(),modal_dismiss()→modal_close_button();textis nowlabel, and all three close constructors pass...on as attributes of the button element (modal_dismiss()silently dropped...)alert_button()→alert_close_icon()Wire protocol is unchanged (
bsides:modalShow/bsides:modalClose,upload_start/upload_cancel); the bundles are rebuilt only becausefile.tscomments name the R verbs. NEWS carries one breaking-changes bullet listing every rename.Also adds
openspec/specs/function-naming/spec.md, which records the contract so future components follow it, and archives the change.Verification:
devtools::check()0 errors / 0 warnings / 0 notes;devtools::test()505 pass; repo-wide grep finds no old name outside NEWS and the archived change.🤖 Generated with Claude Code