fix: preserve production dependencies in omitted SBOMs - #9935
Closed
rootsec1 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm sbomcurrently applies--omitthrough Arborist query dependency-type selectors. Those selectors also match a package reached through an omitted edge, so--omit=devdrops a production dependency when the same installed package is also referenced as a development dependency.Filter the selected nodes with Arborist's existing
Node.shouldOmit()semantics instead. A package remains in the SBOM when it is reachable through a non-omitted dependency type, while dependencies exclusive to omitted types continue to be excluded. Workspace selection and SBOM formatting are unchanged, which keeps the compatibility risk limited to correcting false-negative components.The regression test models a hoisted package shared by a production dependency and a root development dependency. It fails without the change and passes with it.
node . testand the repository lint checks pass.Closes #7909