Repository navigation
[pull] main from Stade-App:main - #23
Merged
Merged
Conversation
Adds a contributing guide covering how to build and test the project, what a pull request is expected to carry, which areas need a conversation before any code is written, and which additions will be turned down whatever shape they arrive in. The guide asks for English throughout, so the project now follows its own request. Workflow names and notes, the checks in the handshake, the last remaining comments and a test fixture were all still in Turkish. A language's own name and the sound title a test is actually about stay as they are. One of those was reaching people: a message that failed to encrypt reported the reason in Turkish whatever language the app was set to. It now reads in the language the reader chose. The readme said the app spoke two languages when it speaks five, and offered receipts the app deliberately does not have.
The contributing guide now says that Stade, Stadium, Stadey, Paddy and Radar are names rather than descriptions, and stay in Latin script wherever the app is read. The app was not doing that. Turkish and Korean already kept Stadium as it is, but Persian and Arabic had turned it into an ordinary word for a sports ground, and both had done the same to Radar. Korean had spelled out Radar in its own script in one place and dropped the name Stade from a question about Stade. Thirty-seven readings across three languages now carry the name the rest of the app uses.
Looking for something said earlier meant scrolling for it. Every conversation, whether with one person, a group or a Stadium, now has a magnifier in its bar. Typing gathers the matches, the count shows which one is in view, and the arrows walk through them, each landing centred and briefly lit the same way a tapped notification does. The Radar screen carried a gear that looked like the one that opens the app's own settings while doing something else entirely, and it sat flat against a bar whose other buttons are raised discs. It is now a dial, in the same disc as the rest.
Both pages that show who you are drew their own bar, so switching between them slid one copy out while an identical copy slid in, and the name and picture appeared to travel although they never changed. There is now a single bar, drawn once above the pages rather than inside them. It does not move at all between the two. Only the buttons on its right, which genuinely differ, swap over: the ones leaving fade and shrink away, the ones arriving grow into place. The bar still slides out of sight on the way to a page that has no business showing it. Pulling it out meant the search field had to move as well, and the Chats page reads what was typed there to decide what to list, so what was typed now lives with the bar and the page reads it from there.
The bar reaches up behind the status bar and already accounts for it, but the page beneath was leaving room for the status bar a second time, so an empty band sat between the bar and the first chat. The page now starts exactly where the bar ends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )