fix(demo): Git safe.directory for demo-smoke CI - #14
Merged
Conversation
Composer path repositories mount the bundle at /var/auth-kit-bundle with host-owned files; without safe.directory Composer cannot symlink the local package and the demo returns HTTP 500 in demo-smoke.
FrankenPHP reboots workers after cache:clear during make up; the single-shot curl in demo-smoke often runs before workers are ready and returns HTTP 500. Retry for up to 60s like other bundle demos.
Twig compiles calls in _slide_to_confirm_assets.html.twig even inside
{% if %}, so demo-smoke HTTP 500 when slide-to-confirm is not installed.
Register no-op stubs until the optional bundle provides real functions.
Ignore optional stub closure lines when slide-to-confirm is present in dev dependencies; keep a regression test for demo installs without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/var/auth-kit-bundleas a Gitsafe.directoryin the demo Dockerfile and entrypointTest plan
/en/login)Made with Cursor