Repository navigation
Merged
Conversation
…first (REQ-TWIG-001, REQ-TWIG-002) - TwigPathsPass prepends templates/bundles/NowoAuditKitBundle/ when present and appends src/Resources/views under the NowoAuditKitBundle namespace. - Timeline partial, docs and spec now use @NowoAuditKitBundle/...; the automatic @NowoAuditKit namespace keeps working in 1.x and is deprecated. - USAGE: "Overriding templates" (subpath table, override vs upgrade, freeze rule, procedure, recovery). CHANGELOG/UPGRADING under Unreleased. - Tests: TwigPathsPass unit test, bundle build() test, TwigBundle kernel test (namespace resolves, application override wins). - PHPUnit: 11.5 config schema and #[CoversClass] (clears 2 runner deprecations).
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the remaining DETAILS gaps REQ-TWIG-001 and REQ-TWIG-002.
TwigPathsPass(TWIG_NAMESPACE = 'NowoAuditKitBundle') registerssrc/Resources/viewsunder@NowoAuditKitBundleon the native Twig loader. The timeline partial, USAGE and spec 003 now use@NowoAuditKitBundle/action_log/_timeline.html.twig. Symfony's automatic@NowoAuditKitnamespace still resolves the same files in 1.x (deprecated, documented in UPGRADING).prependPath()fortemplates/bundles/NowoAuditKitBundle/when it exists, thenaddPath()for the bundle views, so application overrides always win. USAGE gains "Overriding templates": subpath table, override-vs-upgrade table, freeze rule, procedure, recovery.TwigPathsPassTest(addPath/prependPath, no-op without loader, alias chain),NowoAuditKitBundleTest::testBuildRegistersTheTwigPathsPass,TwigNamespaceIntegrationTest(real TwigBundle kernel: namespace resolves to the bundle file; app override is the first path and wins).#[CoversClass]attribute (clears the 2 runner deprecations).Checks (local)
cs-check, rector-dry, phpstan, igor, validate-translations, check-twig-extra, check-no-raw-html-form, composer-sync, test-coverage-100 (734/734), demo release-check; demo
debug:twiglists@NowoAuditKitBundle.🤖 Generated with Claude Code