feat(streaming): polling モードで main チャンネル相当の通知・メンションを配信する - #60
Merged
Conversation
ポーリングループの対象がノート系購読だけで、main チャンネル (通知/ メンション) の取得経路が存在しなかった (notedeck#1003)。main 購読を 検出して i/notifications / notes/mentions を定期取得し、WS と同じ StreamEvent::Notification / Mention として emit_both で配る。下流の query ルーティング・OS 通知・未読バッジは WS モードとそのまま共通。 初回サイクルはカーソル確立のみで emit しない — 過去分をまとめて配ると OS 通知が大量発火するため。 Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
ポーリングモードでは通知カラム・メンションカラムが初期ロード後いっさい更新されない (notedeck-dev/notedeck#1003)。ポーリングループの対象がノート系購読 (
SubscriptionTarget::Notes) だけで、main チャンネル (通知/メンション) の取得経路がそもそも実装されていなかった。何を
SubscriptionTarget::Mainの購読 (#984 の dedup によりアカウントあたり高々 1 本) を検出し、i/notificationsとnotes/mentionsを定期取得するStreamEvent::Notification/StreamEvent::Mentionとしてemit_bothで配る。下流 (notedeck の query ルーティング・OS 通知・未読バッジ・SSE) は WS モードとそのまま共通で動く🤖 Generated with Claude Code