fix(streaming): main チャンネル購読をアカウント単位で 1 本に dedup する - #58
Merged
Conversation
Misskey の main は shouldShare チャンネルで、同一 WS 接続への 2 本目の connect はサーバーが黙って無視する (ack も返らない)。従来は購読のたびに 新規 ID で connect していたため、通知カラムとメンションカラムが併存すると 後から張った側にイベントが一切届かなかった (notedeck#984)。 - subscribe_target: Main は既存購読 ID を返す (check-and-insert を原子化) - unsubscribe / suspend_subscription: Main は no-op (共有チャンネルのため カラム都合で切ると OS 通知・未読バッジまで巻き添えになる。解放は disconnect のみ) Co-Authored-By: Claude Fable 5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
Misskey の
mainはshouldShareチャンネルで、同一 WS 接続への 2 本目の connect をサーバーが黙って無視する (ack も返らない)。従来は購読のたびに新規 ID で connect していたため、notedeck で通知カラムとメンションカラムが併存すると後から張った側にイベントが一切届かなかった (notedeck-dev/notedeck#984)。さらに main には通知・メンション・OS 通知・未読バッジがすべてぶら下がるため、カラム都合の unsubscribe / suspend で main を切ると他の消費者ごと無音になる (notedeck-dev/notedeck#1002)。
変更
subscribe_target:SubscriptionTarget::Mainは既存の購読 ID を返す (check-and-insert を原子化し、send 失敗時はロールバック)unsubscribe/suspend_subscription: Main に対しては no-op。解放経路はdisconnectのみ🤖 Generated with Claude Code