feat: make OCSP timeout configurable via --ocsp-timeout flag - #1366
Open
shashankvarma499 wants to merge 1 commit into
Open
feat: make OCSP timeout configurable via --ocsp-timeout flag#1366shashankvarma499 wants to merge 1 commit into
shashankvarma499 wants to merge 1 commit into
Conversation
The OCSP HTTP client timeout was hardcoded to 2 seconds, which is insufficient for environments with high-latency OCSP responders. Add a --ocsp-timeout flag to 'notation verify' and 'notation blob verify' so users can override the default 2 second timeout. Fixes notaryproject#976 Signed-off-by: Shashank Varma <[email protected]>
shashankvarma499
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
September 11, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OCSP HTTP client timeout in the revocation validator is hardcoded to 2 seconds, which is too short for environments with high-latency OCSP responders (e.g. slow or high-latency networks), causing frequent verification timeouts.
This change introduces a
--ocsp-timeoutflag onnotation verifyandnotation blob verify, allowing users to override the default 2 second timeout. The default behavior is unchanged.Changes
DefaultOCSPTimeoutconstant and thread anocspTimeoutparameter throughNewRevocationValidator.--ocsp-timeoutflag (default2s) tonotation verifyandnotation blob verify.Fixes #976
Verification
go build ./...go vet ./...go test ./internal/revocation/... ./cmd/notation/internal/verify/... ./cmd/notation/...