Repository navigation
sdk: bind verification cache entries to signatures - #1508
Merged
yukibtc merged 1 commit intoNov 3, 2026
Merged
Conversation
Only skip signature verification when both the event ID and signature match a previously verified event. Reverify different signatures before replacing the entry so valid alternative signatures remain accepted. Add regression coverage for invalid signatures on cache misses and hits, cache preservation, and alternative valid signatures.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
13 tasks
yukibtc
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The verification cache skips signature verification for any event with a cached ID, but event IDs do not cover signatures. A relay can therefore send authentic event contents with an invalid signature and have that copy accepted, potentially leaving applications with a stored or delivered event that fails later verification.
Fix
Cache the verified signature alongside each event ID and skip verification only when both match. Verify a different signature before replacing the cache entry, so alternative valid Schnorr signatures remain accepted and invalid signatures leave the verified entry intact.
Validation
cargo test -p nostr-sdk --lib shared::testsjust precommit