Skip to content

fix: base release version on max of git tag and published NuGet version - #39

Merged
nord- merged 2 commits into
masterfrom
ci/fix-release-version-source-of-truth
Jul 3, 2026
Merged

nord- merged 2 commits into
masterfrom
ci/fix-release-version-source-of-truth

Conversation

@nord-

@nord- nord- commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • v1.11.0/v1.11.1 were tagged, published to NuGet, then the git tags were deleted — but NuGet has no unpublish, so those versions stayed live permanently
  • release.yml computed the next version purely from git tags, so it kept bumping from v1.10.x, producing v1.10.3 while NuGet's "latest" resolves to the already-published v1.11.1 (higher SemVer wins) — newer releases were effectively invisible to consumers
  • Fix: compute the base version as max(latest git tag, highest published NuGet version) before applying the bump

Test plan

  • Merge with patch label → confirms release.yml computes v1.11.2 (max(1.10.3, 1.11.1) + patch) instead of v1.10.4
  • Verify v1.11.2 appears on NuGet.org after the publish job runs

Tags v1.11.0/v1.11.1 were deleted after being published to NuGet, but
NuGet has no unpublish — those versions stayed live there permanently.
Since release.yml computed the next version from git tags alone, it
kept bumping from v1.10.x, producing v1.10.3 while NuGet's "latest"
resolves to the already-published v1.11.1 (higher SemVer wins), so
newer releases were effectively invisible to consumers.
Copilot AI review requested due to automatic review settings July 3, 2026 08:56
@nord- nord- added the patch label Jul 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the release workflow’s version calculation so new releases remain visible on NuGet even when git tags were deleted, by basing the next version on the maximum of the latest git tag and the highest published NuGet version.

Changes:

  • Add a step to query the highest published NuGet version for NiceEntry.
  • Update version calculation to choose max(latest_tag, highest_nuget) before applying the bump (major/minor/patch) based on PR labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml Resolved
…ck to 0.0.0

The previous curl -sf ... || true swallowed timeouts, DNS failures, and
5xx errors the same as a genuine 404, silently reverting to git-tag-only
versioning on transient failures - the exact bug this workflow now
guards against.
@nord-
nord- merged commit 471b45f into master Jul 3, 2026
1 check passed
@nord-
nord- deleted the ci/fix-release-version-source-of-truth branch July 3, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants