Repository navigation
fix: base release version on max of git tag and published NuGet version - #39
Merged
Merged
Conversation
Tags v1.11.0/v1.11.1 were deleted after being published to NuGet, but NuGet has no unpublish — those versions stayed live there permanently. Since release.yml computed the next version from git tags alone, it kept bumping from v1.10.x, producing v1.10.3 while NuGet's "latest" resolves to the already-published v1.11.1 (higher SemVer wins), so newer releases were effectively invisible to consumers.
There was a problem hiding this comment.
Pull request overview
Adjusts the release workflow’s version calculation so new releases remain visible on NuGet even when git tags were deleted, by basing the next version on the maximum of the latest git tag and the highest published NuGet version.
Changes:
- Add a step to query the highest published NuGet version for
NiceEntry. - Update version calculation to choose
max(latest_tag, highest_nuget)before applying the bump (major/minor/patch) based on PR labels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ck to 0.0.0 The previous curl -sf ... || true swallowed timeouts, DNS failures, and 5xx errors the same as a genuine 404, silently reverting to git-tag-only versioning on transient failures - the exact bug this workflow now guards against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
patchlabel → confirms release.yml computes v1.11.2 (max(1.10.3, 1.11.1) + patch) instead of v1.10.4