Skip to content

ci: chain NuGet publish directly after release job - #33

Merged
nord- merged 1 commit into
masterfrom
feat/fix-nuget-publish-trigger
Jun 11, 2026
Merged

nord- merged 1 commit into
masterfrom
feat/fix-nuget-publish-trigger

Conversation

@nord-

@nord- nord- commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • GITHUB_TOKEN-triggered events triggar inte andra workflows — release: published i publish.yml har aldrig fungerat
  • Lägger till ett publish-jobb i release.yml med needs: release så publish körs direkt i samma workflow-körning
  • Versionen skickas via job outputs (release.outputs.version)
  • publish.yml behåller push: tags och workflow_dispatch som fallback

Test plan

  • Merga en PR till master och verifiera att båda jobben (release och publish) körs i samma workflow-körning

GITHUB_TOKEN-triggered events do not fire other workflows, so the
release: published trigger in publish.yml never worked. Fix by adding
a publish job in release.yml that runs via needs: release, receiving
the version via job outputs. publish.yml keeps push: tags and
workflow_dispatch as fallback triggers.
Copilot AI review requested due to automatic review settings June 11, 2026 08:15
@nord-
nord- merged commit bf7e360 into master Jun 11, 2026
2 checks passed
@nord-
nord- deleted the feat/fix-nuget-publish-trigger branch June 11, 2026 08:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release/publish automation so NuGet publishing happens reliably by chaining the publish step directly after the release job (since GITHUB_TOKEN-created releases/tags don’t trigger other workflows).

Changes:

  • Exposes the calculated version from release as a job output and passes it to a new publish job in the same workflow run.
  • Adds a publish job to release.yml that packs and pushes the NuGet package after the release is created.
  • Changes publish.yml to trigger on tag pushes (and keeps workflow_dispatch as a fallback).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/release.yml Adds a downstream publish job that uses the release job’s version output to pack and push to NuGet.
.github/workflows/publish.yml Switches fallback triggering from release: published to push: tags plus workflow_dispatch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +4 to +6
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants