Repository navigation
Require NNUE for bench and report the signature in CI - #77
Merged
Merged
Conversation
The CI bench check compared against a stale signature from before the Stockfish 19 network. Bench without a loaded network silently fell back to a different evaluation, so it now refuses to run. The signature does not depend on compiler, ISA or TT size (16 to 4096 MiB all give 993713), so CMake rejects TT sizes below 16 MiB and CI builds for x86-64-v3 and prints the expected and actual signature. Bench: 993713 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI bench check compared against
Bench: 696698, a signature from before the Stockfish 19 network, so it failed on every commit. The signature itself does not depend on the machine: GCC 15 (native, x86-64-v3, x86-64-v2) and Clang 23 all give 993713, and so does every TT size from 16 to 4096 MiB.benchrefuses to run without a loaded NNUE network instead of silently falling back to another evaluation and printing a different node count.SCE_TT_SIZE_MBbelow 16 MiB, the range for which the signature is defined.SCE_TARGET_ARCHcache option (defaultnative); CI builds withx86-64-v3and prints the expected and actual signature before comparing.Search code is unchanged: depthbench nodes and move hashes are identical to deploy-elo 13235ba. GCC 15 tests pass.
🤖 Generated with Claude Code