fix(markdown): update monospace font-face for preformatted code blocks on Windows#9015
fix(markdown): update monospace font-face for preformatted code blocks on Windows#9015bmuenzenmeyer wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The override only redefines Reviewed by Cursor Bugbot for commit 976454f. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9015 +/- ##
=======================================
Coverage 74.55% 74.56%
=======================================
Files 100 100
Lines 8801 8803 +2
Branches 325 324 -1
=======================================
+ Hits 6562 6564 +2
Misses 2235 2235
Partials 4 4 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
This PR adjusts Markdown fenced code block typography so box-drawing/ASCII-art diagrams render with consistent character widths on Windows by switching those blocks to a system monospace font stack (instead of IBM Plex Mono) via a scoped CSS variable override.
Changes:
- Override
--font-ibm-plex-monowithinpreto a system monospace stack to avoid per-glyph fallback width mismatches on Windows. - Add detailed rationale in
markdown.cssexplaining the box-drawing glyph issue and why the override is scoped topre.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
|
|
@bmuenzenmeyer can you bump ui-components up a patch |
Description
At @avivkeller's suggestion nodejs/doc-kit#910 could be fixed upstream in ui-components, so as to improve all usages
Validation
Setup: add this to any markdown on the site
Before
After
Related Issues
Closes nodejs/doc-kit#909
Closes nodejs/doc-kit#910
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.