Skip to content

chore: remove root packageManager nonstandard field#9011

Closed
shivarm wants to merge 3 commits into
nodejs:mainfrom
shivarm:remove-packageManager
Closed

chore: remove root packageManager nonstandard field#9011
shivarm wants to merge 3 commits into
nodejs:mainfrom
shivarm:remove-packageManager

Conversation

@shivarm

@shivarm shivarm commented Jul 16, 2026

Copy link
Copy Markdown

Description

Validation

Related Issues

closes: ##9004

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@shivarm
shivarm requested a review from a team as a code owner July 16, 2026 03:19
@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Error Error Jul 18, 2026 4:50am

Request Review

@cursor

cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Metadata and CI-only workflow changes; no runtime application or security-sensitive logic.

Overview
Removes the root packageManager field from package.json so the repo relies on devEngines.packageManager as the single source for the required pnpm version (closes #9004).

The PNPM updater workflow no longer derives the version from the deleted field; after pnpm self-update, it writes devEngines.packageManager.version using the live pnpm --version output via jq --arg.

Reviewed by Cursor Bugbot for commit cf5c0d2. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e5abd86. Configure here.

Comment thread package.json
@avivkeller

Copy link
Copy Markdown
Member

WARNING! Warning: Could not enable corepack because package.json is missing "packageManager" property

Looks like we needed that field

@avivkeller avivkeller closed this Jul 18, 2026
@shivarm
shivarm deleted the remove-packageManager branch July 18, 2026 05:53
@ljharb

ljharb commented Jul 18, 2026

Copy link
Copy Markdown
Member

only if you're using corepack - which you don't need to be.

@shivarm
shivarm restored the remove-packageManager branch July 18, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants