[v26.x backport] http2: fix write deadlock exposed by larger window sizes - #65953
Open
panva wants to merge 2 commits into
Open
[v26.x backport] http2: fix write deadlock exposed by larger window sizes#65953panva wants to merge 2 commits into
panva wants to merge 2 commits into
Conversation
Signed-off-by: Tim Perry <[email protected]> PR-URL: nodejs#63249 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Signed-off-by: Filip Skokan <[email protected]> Assisted-by: Codex
This removes a guard (no reads while write pending) that creates this deadlock, which was added as a security mechanism. This guard is redundant given then other existing mechanisms, and a test is added to demonstrate that. Signed-off-by: Tim Perry <[email protected]> PR-URL: nodejs#65440 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Signed-off-by: Filip Skokan <[email protected]> Assisted-by: Codex
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v26.x-staging #65953 +/- ##
=================================================
+ Coverage 90.24% 90.40% +0.15%
=================================================
Files 729 744 +15
Lines 242760 250426 +7666
Branches 46044 47770 +1726
=================================================
+ Hits 219073 226389 +7316
- Misses 15133 15334 +201
- Partials 8554 8703 +149
🚀 New features to boost your workflow:
|
richardlau
approved these changes
Sep 10, 2026
This comment has been minimized.
This comment has been minimized.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #65440 with a prerequisite partial backport of #63249 to address the reset-cleanup hang seen in #65881.
The #63249 backport only adds peer-reset tracking and allows reset streams to be destroyed after readable
'end'without waiting for pending writes to finish. It preserves 26.x buffered reads, errors, and compat events, without taking the semver-major behavior changes. The #65440 patch is unchanged but present here so that both can be tested together.