Skip to content

vfs: validate ZipProvider parent directories - #65829

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-zip-provider-non-dir-parents
Open

vfs: validate ZipProvider parent directories#65829
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-zip-provider-non-dir-parents

Conversation

@trivikr

@trivikr trivikr commented Sep 5, 2026

Copy link
Copy Markdown
Member

Fixes: #65828

Reject attempts to create archive entries beneath non-directory parents. Cover open, mkdir, and rename in the sync and async APIs.


Assisted-by: codex

Reject attempts to create archive entries beneath non-directory
parents. Cover open, mkdir, and rename in the sync and async APIs.

Signed-off-by: Kamat, Trivikram <[email protected]>
Assisted-by: codex
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.19%. Comparing base (b265340) to head (4a1f731).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/vfs/providers/ziparchive.js 91.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65829   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files         770      770           
  Lines      264410   264434   +24     
  Branches    50230    50252   +22     
=======================================
+ Hits       238449   238495   +46     
+ Misses      16966    16928   -38     
- Partials     8995     9011   +16     
Files with missing lines Coverage Δ
lib/internal/vfs/providers/ziparchive.js 97.68% <91.66%> (-0.25%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: ZipProvider allows creating entries beneath non-directory parents

2 participants