build: fix quiet default for make builds - #65826
Open
codebytere wants to merge 1 commit into
Open
Conversation
The Makefile documents quiet output unless V=1 and sets `V ?= 0`, but it forwards `V=$(V)` to the gyp-generated makefile, which tests `ifdef V`. "0" is a non-empty value there, so every make build has printed the full compiler command lines regardless. Default V to empty so the sub-make takes its quiet_ rules; `make V=1` and V=1 in the environment stay verbose, and the ninja and cpplint checks already compare against 1. Refs: nodejs#26740 Refs: nodejs/build#4419 Signed-off-by: Shelley Vohr <[email protected]>
panva
removed their request for review
September 5, 2026 17:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65826 +/- ##
==========================================
- Coverage 90.19% 90.18% -0.02%
==========================================
Files 770 770
Lines 264410 264410
Branches 50243 50240 -3
==========================================
- Hits 238490 238446 -44
- Misses 16924 16978 +54
+ Partials 8996 8986 -10 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile says builds are quiet unless
V=1(since #26740), but it setsV ?= 0and forwardsV=$(V)to the gyp-generated makefile, which checksifdef V.0is a non-empty value, so every make build has printed the full compiler command lines regardless. On ci.nodejs.org that is most of the log volume: onenode-test-commit-*configuration's console is 12-22 MB with all but ~0.5 MB of it compile commands before the TAP output starts, and a singlenode-test-pull-requestrun adds up to ~480 MB of console on the controller (nodejs/build#4419).This defaults
Vto empty so the sub-make sees noVand uses itsquiet_rules.make V=1, orV=1in the environment, is verbose as before; the ninja and cpplint paths already compare against1and are unchanged.Tests: on a make-configured tree
makenow printsCC(target) …lines andmake V=1prints the full commands;make -n nodeshowsV=/V=1being forwarded.Refs: #26740
Refs: nodejs/build#4419
Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.