src, child_process: fix fatal error on Array prototype pollution - #65791
src, child_process: fix fatal error on Array prototype pollution#65791Soumyadeep765 wants to merge 1 commit into
Conversation
Add an object check in ParseStdioOptions to prevent V8 from crashing with "v8::ToLocalChecked Empty MaybeLocal" when Array.prototype has been polluted. This replaces the fatal error with a controlled JavaScript TypeError (ERR_INVALID_ARG_TYPE). Fixes: nodejs#56531 Signed-off-by: soumyadeep765 <[email protected]> Assisted-by: Antigravity
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
|
This PR proposes a fix for #56531 which has the label
good first issue
AI use policy and guidelines says:
Soumyadeep765@a329954 however contains the following text which suggests that AI was used to automate the fix:
The PR has not followed the Pull Request guide which advises to create a local branch, as described in Step 2: Branch. Changes have been made in the fork's See Pull requests > Step 6: Test
with further details under [BUILDING > Running tests](Running tests) including:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65791 +/- ##
==========================================
- Coverage 90.17% 90.15% -0.03%
==========================================
Files 769 769
Lines 261448 261451 +3
Branches 49674 49655 -19
==========================================
- Hits 235759 235702 -57
- Misses 16736 16770 +34
- Partials 8953 8979 +26
🚀 New features to boost your workflow:
|
Add an object check in ParseStdioOptions to prevent V8 from crashing with "v8::ToLocalChecked Empty MaybeLocal" when Array.prototype has been polluted. This replaces the fatal error with a controlled JavaScript TypeError (ERR_INVALID_ARG_TYPE).
Fixes: #56531
Assisted-by: Antigravity