Skip to content

domain: runtime-deprecate the module - #65074

Closed
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:domain-runtime-deprecation
Closed

domain: runtime-deprecate the module#65074
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:domain-runtime-deprecation

Conversation

@mcollina

@mcollina mcollina commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Promote DEP0032 (node:domain module) from a documentation-only deprecation to a runtime deprecation.

Fixes #10843

@nodejs-github-bot

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added domain Issues and PRs related to the domain subsystem. needs-ci PRs that need a full CI run. labels Aug 6, 2026
@mcollina mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 6, 2026
@mcollina
mcollina force-pushed the domain-runtime-deprecation branch from a0a1112 to b375429 Compare August 6, 2026 10:29
@codecov

codecov Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (219dbd6) to head (6ae58dd).
⚠️ Report is 554 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65074      +/-   ##
==========================================
+ Coverage   90.27%   90.30%   +0.03%     
==========================================
  Files         762      759       -3     
  Lines      247524   248264     +740     
  Branches    46693    46850     +157     
==========================================
+ Hits       223451   224200     +749     
+ Misses      15494    15471      -23     
- Partials     8579     8593      +14
Files with missing lines Coverage Δ
lib/domain.js 95.35% <100.00%> (+0.04%) ⬆️

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
domain: runtime-deprecate the module
6ae58dd 
Promote DEP0032 from a documentation-only deprecation to a runtime
deprecation. Loading the `node:domain` module now emits a
DeprecationWarning with code DEP0032, and the docs are updated to
reflect the Runtime deprecation type.

Signed-off-by: Matteo Collina <[email protected]>
@mcollina
mcollina force-pushed the domain-runtime-deprecation branch from b375429 to 6ae58dd Compare August 6, 2026 12:59
AugustinMauroy
AugustinMauroy reviewed Aug 6, 2026
View reviewed changes
Comment thread doc/api/deprecations.md
@RafaelGSS

RafaelGSS commented Aug 19, 2026

Copy link
Copy Markdown
Member

ping @nodejs/tsc as per #10843

jasnell
jasnell approved these changes Aug 20, 2026
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about time!

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76032/

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76492/

@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76802/

@nodejs-github-bot

nodejs-github-bot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76828/

@mcollina mcollina added notable-change PRs with changes that should be highlighted in changelogs. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @mcollina.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
- Loading data for nodejs/node/pull/65074
✔  Done loading data for nodejs/node/pull/65074
----------------------------------- PR info ------------------------------------
Title      domain: runtime-deprecate the module (#65074)
Author     Matteo Collina <[email protected]> (@mcollina)
Branch     mcollina:domain-runtime-deprecation -> nodejs:main
Labels     domain, semver-major, notable-change, needs-ci, commit-queue
Commits    1
 - domain: runtime-deprecate the module
Committers 1
 - Matteo Collina <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65074
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65074
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Aug 2026 09:30:41 GMT
   ✔  Approvals: 5
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65074#pullrequestreview-4886317665
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-4928034282
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-4973323612
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-4978547462
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-5082073270
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-09-01T14:32:43Z: https://ci.nodejs.org/job/node-test-pull-request/76828/
- Querying data for job/node-test-pull-request/76828/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 3, 2026
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 3, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 3, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Commit Queue failed

✘ GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output 
- Loading data for nodejs/node/pull/65074
✔  Done loading data for nodejs/node/pull/65074
----------------------------------- PR info ------------------------------------
Title      domain: runtime-deprecate the module (#65074)
Author     Matteo Collina <[email protected]> (@mcollina)
Branch     mcollina:domain-runtime-deprecation -> nodejs:main
Labels     domain, semver-major, notable-change, needs-ci, commit-queue
Commits    1
 - domain: runtime-deprecate the module
Committers 1
 - Matteo Collina <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65074
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65074
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Aug 2026 09:30:41 GMT
   ✔  Approvals: 5
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65074#pullrequestreview-4886317665
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-4928034282
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-4973323612
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-4978547462
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/65074#pullrequestreview-5082073270
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-09-02T05:36:59Z: https://ci.nodejs.org/job/node-test-pull-request/76828/
- Querying data for job/node-test-pull-request/76828/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

panva pushed a commit that referenced this pull request Sep 3, 2026
@mcollina @panva
domain: runtime-deprecate the module
6071f8b 
Promote DEP0032 from a documentation-only deprecation to a runtime
deprecation. Loading the `node:domain` module now emits a
DeprecationWarning with code DEP0032, and the docs are updated to
reflect the Runtime deprecation type.

Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #65074
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@panva

panva commented Sep 3, 2026

Copy link
Copy Markdown
Member

Landed in 6071f8b

@panva panva closed this Sep 3, 2026
@panva panva removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@legendecas legendecas legendecas approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@avivkeller avivkeller avivkeller approved these changes
+1 more reviewer
@AugustinMauroy AugustinMauroy AugustinMauroy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

domain Issues and PRs related to the domain subsystem. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

What will Domain be replaced with?

10 participants

@mcollina @nodejs-github-bot @RafaelGSS @panva @jasnell @anonrig @legendecas @marco-ippolito @avivkeller @AugustinMauroy