net: ignore UV_EALREADY in tryReadStart#64530
Open
harjothkhara wants to merge 1 commit into
Open
Conversation
Signed-off-by: harjoth <[email protected]>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64530 +/- ##
==========================================
+ Coverage 90.21% 90.23% +0.01%
==========================================
Files 739 739
Lines 241650 241651 +1
Branches 45542 45553 +11
==========================================
+ Hits 218013 218054 +41
+ Misses 15155 15110 -45
- Partials 8482 8487 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tryReadStart()treated every non-zeroreadStart()result as fatal. Thatincluded
UV_EALREADY, which means the handle is already reading and noadditional action is required.
Ignore
UV_EALREADYwhile preserving the existing socket destruction path forall other read-start errors. Add a loopback regression test that forces this
return value and verifies that the socket remains usable.
Fixes: #62400
Tests:
make -j8tools/test.py test/parallel/test-net-read-start-ealready.jstools/test.py test/parallel/test-net-*.jsmake lint-jsAI assistance: OpenAI Codex assisted with implementation and validation. Local
Claude and Codex review passes reported no actionable findings.