test: fix cp.exec-any-shells test on windows with wsl - #63118
Open
nadalaba wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
needs-ci
Collaborator
Collaborator
Contributor
Author
nadalaba
force-pushed
the
fix-win-shell-test
branch
from
August 5, 2026 16:37
59079b2 to
9d55f7e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63118 +/- ##
==========================================
- Coverage 90.17% 90.14% -0.03%
==========================================
Files 769 769
Lines 261448 261448
Branches 49674 49637 -37
==========================================
- Hits 235759 235684 -75
- Misses 16736 16788 +52
- Partials 8953 8976 +23 🚀 New features to boost your workflow:
|
nadalaba
force-pushed
the
fix-win-shell-test
branch
2 times, most recently
from
August 5, 2026 20:38
b4a0e7e to
fd3e639
Compare
Contributor
|
You asked about rebasing in Slack. Your branch is now more than 500 commits behind due to the passage of time. I would suggest to rebase now in any case. The workflow |
MikeMcC399
added
the
wsl
WSL bash files (from WindowsApps and System32) either cannot be symlinked or don't work as expected from symlinks. This change detects WSL bash and: - Skips testing it if no WSL distro is installed. - Skips symlink tests for all WSL bash executables. Signed-off-by: Nad Alaba <[email protected]>
nadalaba
force-pushed
the
fix-win-shell-test
branch
from
September 4, 2026 14:20
fd3e639 to
975db92
Compare
Contributor
|
Good to see that you rebased and that GitHub Actions CI is now green 🎉 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid symlink failures when WSL bash executables are present on PATH.
WSL bash files (from WindowsApps and System32) either cannot be symlinked
or don't work as expected from symlinks. This change detects WSL bash and: