chore!: remove npm shrinkwrap, use exact dependency versions#1121
Open
Renegade334 wants to merge 2 commits into
Open
chore!: remove npm shrinkwrap, use exact dependency versions#1121Renegade334 wants to merge 2 commits into
Renegade334 wants to merge 2 commits into
Conversation
Renegade334
force-pushed
the
npm-exact-deps
branch
from
July 21, 2026 18:36
1025adf to
c71756e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
=======================================
Coverage 63.27% 63.27%
=======================================
Files 50 50
Lines 8342 8342
=======================================
Hits 5278 5278
Misses 3064 3064 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Renegade334
force-pushed
the
npm-exact-deps
branch
from
July 21, 2026 18:45
c395aca to
9030665
Compare
Contributor
That's not true, as you said after it only works for shallow deps. I'd rather just rename the file to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1078.
We are currently locking consumers' dependency versions by using npm-shrinkwrap.json, which causes npm to lock the dependency tree to the npm-shrinkwrap.json versions when resolving.
We can achieve a similar effect by de-ranging the dependency versions. We weren't actually allowing npm to "choose" a dependency within these semver ranges anyway, because npm-shrinkwrap.json existed.
This approach wouldn't guarantee strict versioning of dependencies-of-dependencies for packages which specify version ranges for their own deps. The alternative would be
bundleDependenciesto basically ship a pre-packed node_modules, which would also give some version control over transitive dependencies, at the expense of quite a bulky package.Either way, it'll be technically breaking because node-core-utils is now subject to external npm
overrides, which shrinkwrap disallowed.