feat(docs): add documentation for doc-kit#889
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 85.04% 85.06% +0.02%
==========================================
Files 179 192 +13
Lines 16496 17450 +954
Branches 1500 1550 +50
==========================================
+ Hits 14029 14844 +815
- Misses 2457 2600 +143
+ Partials 10 6 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
all.html |
19.94 MB | 19.94 MB | -234.00 B (-0.00%) |
AugustinMauroy
left a comment
There was a problem hiding this comment.
Noice !
also we should add a "why doc-kit" section but with a "TBD" and in future have comparison with fuma-docs/docausorus ...
PR SummaryLow Risk Overview Fixes Smaller follow-ons: publish Reviewed by Cursor Bugbot for commit 358158f. Bugbot is set up for automated code reviews on this repo. Configure here. |
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 4 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f035e7. Configure here.
Co-authored-by: Aviv Keller <[email protected]>
CHANGELOG, LICENSE, README are usually defaults, but i want to be affirmative here
relative() consumed the target's final path segment as a common directory
whenever the target was a path prefix of the current page, so
relative('/generators', '/generators/web') returned '.' instead of
'../generators' — which callers appending '.html' turned into a broken
'..html' link. Treat the last segment of `to` as the target itself so it
always survives into the result.
Unreachable in flat page layouts (every existing call site passes
top-level paths, where the stripping loop never runs), so output is
unchanged for those; surfaced by sites feeding nested input directories
to the web generator.
Co-Authored-By: Claude Fable 5 <[email protected]>
|
I spent a lot of time sort of incredulous that Claude suggested there was a nascent bug in doc-kit that our beta, or learn, or webpack had yet to find. So perhaps @avivkeller another pass at d3f2819 |
|
I think what Claude is getting at is that if I navigate from That said, this isn't really a doc-kit issue, rather, it's a consequence of how browsers resolve relative URLs. Redirecting from a URL with a trailing slash behaves differently than redirecting from one without. Claude's change fixes the In practice, this only becomes an issue if all of the following are true:
We intentionally don't enable relative links on our Learn sites, webpack sites, or our main docs site because they can produce obscure, and often incorrect, URLs for exactly this reason. |
|
i purposely made it atomic so it could be reverted, if we so choose. |
|
@bmuenzenmeyer merge when ready |

Description
Introduces the doc-kit documentation site, built with doc-kit!
This also serves as a reasonable simple
webexample.Validation
Getting started suggestion end-state
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.