Skip to content

feat(core): unify trace collection bindings - #51

Merged
nmrtist merged 1 commit into
mainfrom
feat/trace-collections
Aug 7, 2026
Merged

feat(core): unify trace collection bindings#51
nmrtist merged 1 commit into
mainfrom
feat/trace-collections

Conversation

@nmrtist

@nmrtist nmrtist commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Introduce typed, stable trace collection and item identities for item-addressed series.
  • Represent electrophysiology sweeps and pseudo-2D NMR increments through the same trace collection model.
  • Unify initial plots, stacked plots, display-mode projection, styling, and persistence around plot-owned series bindings.
  • Add strict v1 serialization and reference validation without compatibility parsing or migration logic.

User-facing changes

  • Hide legends by default for electrophysiology, pseudo-2D NMR, and true-2D NMR plots while keeping them user-configurable.
  • Resolve electrophysiology labels from the varying voltage or current stimulus and pseudo-2D labels from semantic gradient or delay values.
  • Preserve editable custom labels, visibility, colors, line widths, scaling, ordering, and stable series identities.
  • Expand all trace items when stacking trace collections instead of selecting an arbitrary first item.
  • Add Data inspector controls to show all, hide all, remove, reorder, restyle, and choose individual traces.
  • Preserve authored stack state when switching pseudo-2D datasets between stack, DOSY, and ILT displays.
  • Render DOSY and ILT results as explicit scalar-grid fields through the standard contour pipeline.

Lifecycle and persistence

  • Keep sweep analysis selection in transient invocation state.
  • Capture selection-dependent tables only through explicit creation actions.
  • Prevent unrelated electrophysiology edits from retargeting independently bound channels.
  • Validate collection/item references, field compatibility, tagged sources, and owner-local series ID uniqueness consistently on save and load.
  • Keep the project schema fixed at version 1.

Documentation

  • Update the English and Simplified Chinese electrophysiology and pseudo-2D guides to match the new behavior.

Validation

  • cargo pr-check
  • Documentation build completed successfully.

Add stable item-addressed sources for electrophysiology and pseudo-2D trace collections. Unify stack display, per-series authoring, truthful map fields, and transient analysis selection behind plot-owned bindings. Persist strict v1 references and styling, with aligned user documentation and regression coverage.
@nmrtist
nmrtist merged commit 73c54c4 into main Aug 7, 2026
11 checks passed
@nmrtist
nmrtist deleted the feat/trace-collections branch August 7, 2026 14:13
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant