fix(templates): standardize OAuth conditional loading and fix ScopeGuard bypass - #342
Open
hemantj-cloud wants to merge 1 commit into
Open
fix(templates): standardize OAuth conditional loading and fix ScopeGuard bypass#342hemantj-cloud wants to merge 1 commit into
hemantj-cloud wants to merge 1 commit into
Conversation
…ard bypass - Conditionally load OAuthModule only when OAUTH_REQUIRED=true to prevent unwanted browser redirects in dev mode - Fix createScopeGuard to bypass scope validation when !OAuthModule.isAuthRequired() - Suppress unconfigured OAuthModule DI warning in index.ts for clean development startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes OAuth 2.1 handling in the
typescript-oauthtemplate to align with industry standards and the MCP specification:Conditional OAuthModule Loading:
OAUTH_REQUIRED=false),OAuthModuleis not loaded, which stops emitting[NITROSTACK_OAUTH]discovery signals and prevents clients (NitroStudio, ChatGPT, Cursor) from opening unwanted browser login popups.OAUTH_REQUIRED=true,OAuthModuleis loaded dynamically and enforces strict token validation.ScopeGuard Enforcement Gate:
createScopeGuardto checkif (!OAuthModule.isAuthRequired()) return true;, preventing unauthenticated local requests from failing withInsufficient scope.Clean Dev Startup:
OAuthModulein DI whenOAUTH_REQUIRED=falseto suppress false-positive container warnings on startup.Testing
OAUTH_REQUIRED=false.OAUTH_REQUIRED=true.