Install init dependencies into a project .venv - #19
Merged
Conversation
Y/Enter on init was a no-op for Python packages (npm-only, and templates have no src/widgets). Create .venv and pip-install into it so deps land in the generated project, not the CLI interpreter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nitrostack-py initanswering Y/Enter now runs the existing install path instead of a no-opnpmin missingsrc/widgets.<project>/.venv(or reuses it) and pip-installsrequirements.txt/pyproject.tomlinto that interpreter, not the CLI’s Python.nitrostack-py installuses the same.venv. Widgetnpm installstill runs only ifsrc/widgetsexists.Test plan
pytest tests/test_cli.py tests/test_cli_install.pynitrostack-py init /tmp/venv-smoke --template python-starter→ Y →.venv/bin/pythonexists andpip show nitrostackworks inside itnstill skips install