Honor the configured ONNX device preference - #4
Open
jmoujaled wants to merge 1 commit into
Open
Conversation
AppConfig.device was defined (default 'cpu') but _get_available_providers ignored it entirely and always auto-selected CoreML > CUDA > CPU, so the setting was dead config. Respect it: 'cpu' forces CPU, 'cuda'/'coreml'/'mps' prefer that provider with a CPU fallback, and 'auto' keeps the previous priority behavior. CPU is always appended as a safety net.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppConfig.deviceexists (defaulting to"cpu") but was never actually used —ONNXTTSEngine._get_available_providers()ignored it and always auto-selectedCoreML > CUDA > CPU. So settingdevicein the config had no effect (e.g. auser asking for
cpustill got CoreML on Apple Silicon). This makes the enginehonor the setting.
Behavior
devicecpuCPUExecutionProvideronlycudaCUDAExecutionProvider(if available) → CPU fallbackcoreml/mpsCoreMLExecutionProvider(if available) → CPU fallbackauto(or unknown)to CPU instead of failing.
autopreserves the existing behavior exactly, so nothing changes for anyonewho hasn't set
device.Notes
devicefield comment is updated to document the accepted values.