ARM: dts: ni-zynq: Fix USB PHY references - #291
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the NI Zynq device tree USB controller nodes to reference the USB PHY using the current phys property (instead of the deprecated/legacy usb-phy), aligning the DTS with the ChipIdea/Zynq USB DT binding expectations so USB continues to function on newer kernels (notably 6.18 per the PR description).
Changes:
- Replace
usb-phy = <&usb_phyX>;withphys = <&usb_phyX>;for&usb0and&usb1in the NI Zynq DTSI.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gratian
approved these changes
Aug 26, 2026
Use the standard phys property for the Zynq USB controllers instead of usb-phy. The ChipIdea driver interprets usb-phy through the generic PHY framework, but the usb-nop-xceiv devices use the legacy USB PHY framework. This causes both controllers to remain probe-deferred, leaving the USB host unavailable and preventing g_ether from finding a UDC. Using phys allows the ChipIdea driver to resolve the legacy PHYs and restores USB host and gadget operation. Assisted-by: Copilot:GPT-5.6-Sol Signed-off-by: Chaitanya Vadrevu <[email protected]>
chaitu236
force-pushed
the
dev/cvadrevu/fix_arm_usb
branch
from
August 26, 2026 14:22
7cd5ef0 to
f91b99a
Compare
Contributor
Author
|
v2: Fix checkpatch error by removing "Reported-by" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update usb dt nodes so that USB works on ARM devices with 6.18 kernel.
Testing
bitbake packagefeed-ni-core && bitbake package-index && bitbake linux-nilrt-arm-safemode