Repository navigation
π Hotfix 2.4.1: distance sorting, search text, native ad media - #28
Merged
Merged
Conversation
added 5 commits
October 3, 2026 00:46
- "Distance" is selectable again in the stations sort dialog and is stored in preferences (it was mapped to "Name"). - The repository sorts by distance in memory, since only it knows the user's position; ascending/descending both work, the list re-sorts as the location changes, and stations with an unknown distance go last. - The DAO orders by title for DISTANCE too, so the list stays stable while the location is unknown (it was ordered by NULL). Fix: distanceInKm returned NaN when the user stands exactly at a station (rounding pushed the cosine past 1). Tests: distance sorting (asc, desc, unknown location, re-sort on a location change), DAO fallback order, the NaN case.
The search field drew its text with colorScheme.onBackground, which in this palette is the background/card color (white in light theme, dark in dark), so typed text vanished in both themes. It now uses the typography's text color.
When an AdMob ad had an icon, the row showed the icon in a 74x66
thumbnail and hid the registered MediaView, which the AdMob validator
reports as 0x0 ("media views smaller than 120x120 will be
demonetized"). The thumbnail is now always the ad's media at 120x120
(as with Yandex), and the icon moves to the small slot next to the "Ad"
label. Android and iOS.
- Android 2.4.0 -> 2.4.1 (versionCode 2401).
- iOS app 1.1.0 (3) -> 1.1.1 (4); the widget extension gets the same version and build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
π§ Distance sorting is back
NULL).distanceInKmreturnedNaNwhen the user stands exactly at a station (rounding pushed the cosine past 1), which would show "NaN km" and break the sort.π Invisible search text
colorScheme.onBackground. In this palette that is the background/card color (white in the light theme, dark in the dark theme), so typed text vanished in both themes. It now uses the typography's text color. All search screens share this field.π’ AdMob native ad media view
MediaView. The AdMob validator reported it as 0x0: "media views smaller than 120x120 will be demonetized".π Version
Review notes
DISTANCE = 0is the proto default.NaNcase.