fix(threads): show new thread immediately instead of only after reopening chat - #6645
Draft
mahibi wants to merge 1 commit into
Draft
fix(threads): show new thread immediately instead of only after reopening chat#6645mahibi wants to merge 1 commit into
mahibi wants to merge 1 commit into
Conversation
…ning chat Starting a new thread showed the message as a normal chat message until the chat was reopened. Two gaps caused this: - OfflineFirstChatRepository.sendChatMessage() discarded the server's response after a successful send and only updated the temp message's sendStatus, so the correct isThread/threadId/threadTitle from the server was never persisted until a later resync (e.g. on reopening the chat). Now the authoritative response is persisted right away, replacing the temp row. - The optimistic temp message itself did not carry isThread/ threadTitle at all, and ChatViewModel.handleThreadMessages() misclassified that temp message (isThread=true, threadId=null, not yet confirmed by the server) as a thread reply and filtered it out of the normal chat view. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <[email protected]>
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33855916262/artifacts/9930387841 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a new thread showed the message as a normal chat message until the chat was reopened. Two gaps caused this:
Assisted-by: Claude Code:claude-sonnet-5
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)