fix(conversationlist): Retry conversation sync - #6611
Open
rapterjet2004 wants to merge 2 commits into
Open
Conversation
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33525362576/artifacts/9810626068 |
…rs on slow networks On a slow/unstable connection (e.g. GPRS), the room-list fetch can fail with a transient error like StreamResetException, which was silently swallowed. On first launch with an empty local cache this left the conversation list blank with no explanation and no way to recover short of restarting the app. Retry the fetch a few times to ride out transient failures, and only when retries are exhausted and there is nothing cached locally to show, surface the error through the existing error-dialog UI so the user knows the sync failed. Signed-off-by: rapterjet2004 <[email protected]>
…retries Retrying immediately on a slow/unstable connection tends to hit the same transient failure again right away. Wait between retry attempts, backing off exponentially (1s, 2s, 4s, capped at 8s) instead of retrying instantly. Assisted-by: Claude Code:claude-sonnet-5 Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
issue-6264-slow-internet-fetch
branch
from
September 2, 2026 17:29
4976d71 to
620f12f
Compare
mahibi
approved these changes
Sep 2, 2026
mahibi
left a comment
mahibi
left a comment
Collaborator
There was a problem hiding this comment.
lgtm.
i added a commit for backoff handling.
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33661377644/artifacts/9859105980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(conversationlist): Retry conversation sync and surface fetch errors on slow networks
On a slow/unstable connection (e.g. GPRS), the room-list fetch can fail with a transient error like StreamResetException, which was silently swallowed. On first launch with an empty local cache this left the conversation list blank with no explanation and no way to recover short of restarting the app.
Retry the fetch a few times to ride out transient failures, and only when retries are exhausted and there is nothing cached locally to show, surface the error through the existing error-dialog UI so the user knows the sync failed.
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)