Adding confirmation prompt on leave conversation action - #6608
Conversation
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33194320039/artifacts/9695340256 |
|
fine for starters I suppose @rapterjet2004 but see my original comment that this should be a snackbar with faked/delayed execution, see #6607 (comment) - we should not block users with modals - neither does email but gives you a way to restore. So fine to merge I think, but we should improve this in the future. |
|
Implemented the suggestions Screen_recording_20260831_095409.webm |
…rsation via swipe Swiping left on a conversation triggered leaving it immediately with no way to confirm or cancel, making it easy to accidentally leave a group. Show a confirmation dialog, matching the existing delete conversation dialog pattern. Fixes #6607 Signed-off-by: rapterjet2004 <[email protected]>
…ackbar The blocking confirmation dialog interrupted the swipe-to-leave flow. Show a snackbar with an Undo action instead, matching the pattern email clients use. The room is hidden optimistically and the actual leave request is only sent once the snackbar times out without being undone, so leaving stays reversible even for rooms only a moderator could re-add you to. Addresses review feedback on #6607 Signed-off-by: rapterjet2004 <[email protected]>
aecc42d to
d44bec1
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33610575498/artifacts/9840628929 |
Signed-off-by: Andy Scherzinger <[email protected]>
|
/backport to stable-25.0.x |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33621972027/artifacts/9845101817 |
|
The backport to # Switch to the target branch and update it
git checkout stable-25.0.x
git pull origin stable-25.0.x
# Create the new backport branch
git checkout -b backport/6608/stable-25.0.x
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9c7d97d7 d44bec19 08188ef9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6608/stable-25.0.xError: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401 Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable-25.0.x |
|
The backport to # Switch to the target branch and update it
git checkout stable-25.0.x
git pull origin stable-25.0.x
# Create the new backport branch
git checkout -b backport/6608/stable-25.0.x
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9c7d97d7 d44bec19 08188ef9
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6608/stable-25.0.xError: Failed to clone repository: Failed to create working tree: error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401 Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
3 participants
fix(conversationlist): Add confirmation dialog before leaving a conversation via swipe
Swiping left on a conversation triggered leaving it immediately with no way to confirm or cancel, making it easy to accidentally leave a group. Show a confirmation dialog, matching the existing delete conversation dialog pattern.
🖼️ Screenshots
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)