-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat(taskprocessing): add edit image task #64028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCP\TaskProcessing\TaskTypes; | ||
|
|
||
| use OCP\IL10N; | ||
| use OCP\L10N\IFactory; | ||
| use OCP\TaskProcessing\EShapeType; | ||
| use OCP\TaskProcessing\ITaskType; | ||
| use OCP\TaskProcessing\ShapeDescriptor; | ||
|
|
||
| /** | ||
| * This is the task processing task type for editing images | ||
| * @since 36.0.0 | ||
| */ | ||
| class ImageToImage implements ITaskType { | ||
| /** | ||
| * @since 36.0.0 | ||
| */ | ||
| public const string ID = 'core:image2image'; | ||
|
|
||
| private IL10N $l; | ||
|
|
||
| /** | ||
| * @param IFactory $l10nFactory | ||
| * @since 36.0.0 | ||
| */ | ||
| public function __construct( | ||
| IFactory $l10nFactory, | ||
| ) { | ||
| $this->l = $l10nFactory->get('lib'); | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| * @since 36.0.0 | ||
| */ | ||
| #[\Override] | ||
| public function getName(): string { | ||
| return $this->l->t('Edit image'); | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| * @since 36.0.0 | ||
| */ | ||
| #[\Override] | ||
| public function getDescription(): string { | ||
| return $this->l->t('Edit an image based on a text description of the changes'); | ||
| } | ||
|
|
||
| /** | ||
| * @return string | ||
| * @since 36.0.0 | ||
| */ | ||
| #[\Override] | ||
| public function getId(): string { | ||
| return self::ID; | ||
| } | ||
|
|
||
| /** | ||
| * @return ShapeDescriptor[] | ||
| * @since 36.0.0 | ||
| */ | ||
| #[\Override] | ||
| public function getInputShape(): array { | ||
| return [ | ||
| 'input' => new ShapeDescriptor( | ||
| $this->l->t('Input images'), | ||
| $this->l->t('The images to edit'), | ||
| EShapeType::ListOfImages | ||
| ), | ||
| 'prompt' => new ShapeDescriptor( | ||
| $this->l->t('Prompt'), | ||
| $this->l->t('Describe the changes you want to make to the image'), | ||
| EShapeType::Text | ||
| ), | ||
| ]; | ||
| } | ||
|
|
||
| /** | ||
| * @return ShapeDescriptor[] | ||
| * @since 36.0.0 | ||
| */ | ||
| #[\Override] | ||
| public function getOutputShape(): array { | ||
| return [ | ||
| 'output' => new ShapeDescriptor( | ||
| $this->l->t('Output image'), | ||
| $this->l->t('The edited image'), | ||
| EShapeType::Image | ||
| ), | ||
| ]; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple input images but only one output image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is in case you want to combine images. For example you have a picture of a cat and one of a hat and want the output to be the cat with that specific hat. Might make sense to have multiple output images, but I wrote all the implementations with one output image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, just thought it might have been an oversight :)