Fix: enforce authorization in template field endpoints#5875
Merged
Conversation
rikled
marked this pull request as ready for review
July 17, 2026 19:18
elzody
force-pushed
the
fix/fieldsendpoint
branch
2 times, most recently
from
July 22, 2026 21:16
494b848 to
ec39d2f
Compare
Signed-off-by: Hendrik Leidinger <[email protected]> Assisted-by: Claude Code:Opus 4.8
elzody
force-pushed
the
fix/fieldsendpoint
branch
from
July 24, 2026 17:38
6af86fc to
f7c9786
Compare
elzody
approved these changes
Jul 24, 2026
Collaborator
|
/backport to stable34 |
Collaborator
|
/backport to stable33 |
Collaborator
|
/backport to stable32 |
Collaborator
|
/backport to stable31 |
Collaborator
|
/backport to stable30 |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Code:Opus 4.8
Summary
extractFields and fillFields resolved a global fileId via rootFolder->getFirstNodeById(), which searches across all users' storage. Any authenticated user could pass an arbitrary id to read another user's file contents or fill/overwrite it.
Changes:
Because resolution is now user-scoped, getPermissions() reflects the caller's share-level rights, making the permission check meaningful.
Checklist