Refactor provider registration and implement multiple services - #431
Open
marcelklehr wants to merge 7 commits into
Open
Refactor provider registration and implement multiple services#431marcelklehr wants to merge 7 commits into
marcelklehr wants to merge 7 commits into
Conversation
… at the same time Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
marked this pull request as ready for review
September 9, 2026 10:27
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <[email protected]>
lukasdotcom
reviewed
Sep 10, 2026
lukasdotcom
left a comment
lukasdotcom
left a comment
Member
There was a problem hiding this comment.
Looks nice I've tried it out and it works well on my dev instance. A few things that caught my attention while trying it out though:
-
Quota rules seem to apply to all services, but there is still a usage quota for each individual service. Probably worth it to keep that consistent and allow for specifying a service for quota rules too.
-
Model list here seems to need to be reloaded every single time to see all the models (That might be on purpose though).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #148
fixes #229
🤖 AI (if applicable)