fix(components): warn when hits_and_kdst_from_files skips a file - #974
Closed
aniruddhaadak80 wants to merge 1 commit into
Closed
aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
hits_and_kdst_from_files catches NoSuchNodeError from load_dst and continues with the next file without any warning, so a missing hits or kdst table looks like empty input. Emit a UserWarning naming the skipped file while preserving the existing skip behavior, and cover it with a regression test. Fixes next-exp#956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hits_and_kdst_from_filescatchesNoSuchNodeErrorfromload_dst.Why
The existing catch continues with the next file without any signal, so a missing hits or kdst table is indistinguishable from empty input. Emitting a
UserWarningmakes the skip visible while preserving the function's current skip behavior.Tests
This contribution was prepared entirely through the GitHub API (remote-only); tests were not run locally.
Targeted:
Full suite (same command used by the
Test suiteworkflow):Fixes #956