Conversation
gonzaponte
reviewed
Sep 28, 2026
Comment on lines
+176
to
+179
| apply_nan_cut = fl.map( select_no_nan() | ||
| ,item = 'dst' | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
this you can do directly like fl.map(discard_nan_values, item = 'dst')
Comment on lines
+737
to
+739
| return pd.DataFrame( dict( mu = new_mu | ||
| , nevents = df.nevents.sum()) | ||
| , index=[0]) |
Comment on lines
+49
to
+53
| kdst = kdst[~(kdst.DT.isna())] | ||
| kdst = kdst[~(kdst.X.isna())] | ||
| kdst_nan = kdst[~(kdst.Y.isna())] | ||
|
|
||
| return kdst_nan |
Collaborator
There was a problem hiding this comment.
why is the last selection special and gets a different name?
Comment median() in NormStrategy (should remove it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some changes done in zemrude to: add a new config file for MC, address some errors arising from the new python version, include a new function to merge maps and add new arguments to set S2e range in control plots.