Handle masked SiPMs in Pyrrha - #970
Merged
Merged
Conversation
gonzaponte
reviewed
Sep 9, 2026
Ian0sborne
force-pushed
the
fix-pyrrha-masked-sipms
branch
from
September 21, 2026 15:00
42b2156 to
5fd4816
Compare
gonzaponte
reviewed
Sep 21, 2026
gonzaponte
reviewed
Sep 22, 2026
Ian0sborne
force-pushed
the
fix-pyrrha-masked-sipms
branch
from
September 25, 2026 09:57
596bd30 to
1077d59
Compare
gonzaponte
approved these changes
Sep 25, 2026
gonzaponte
left a comment
gonzaponte
left a comment
Collaborator
There was a problem hiding this comment.
Fixes the handling of masked sipms in the pyrrha configuration of irene. Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue encountered with Pyrrha whereby the code wouldn't handle masked SiPMs.