Skip to content

Feature/ntm/3.3 - #1289

Open
nwx-david-wolff wants to merge 4 commits into
devfrom
feature/ntm/3.3
Open

Feature/ntm/3.3#1289
nwx-david-wolff wants to merge 4 commits into
devfrom
feature/ntm/3.3

Conversation

@nwx-david-wolff

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

13 issues fixed, 2 skipped across 114 files

Category Fixes
Contractions 4
FirstPerson (rewrite) 3
FirstPersonPlural (rewrite) 3
FollowTheStepsTo (rewrite) 1
OxfordComma (rewrite) 2
Skipped (needs manual review) Reason
docs/threatmanager/3.3/administration/serviceaccounts.md:61 — Netwrix.Contractions False positive. The rule matched 'is Not vulnerable', but 'Not vulnerable' is a literal UI status label (bolded), not a negation. Contracting to 'isn't' would misrepresent the product UI.
docs/threatmanager/3.3/administration/threats/threats.md:131 — Netwrix.FirstPerson 'Assigned to me' is a literal UI filter option value shown in the product. Rewriting it would misrepresent the interface.

Ask @claude on this PR if you'd like an explanation of any fix.

@github-actions

Copy link
Copy Markdown
Contributor

Code Review

Reviewed the non-content changes in this PR (new Threat Manager 3.3 version). Scope: src/config/products.js, sidebars/threatmanager/3.3.js, the _category_.json files, and build/routing correctness (broken links, images, anchors). Documentation prose/style is handled by a separate workflow and was not reviewed.

No build-breaking or correctness issues found. Details:

  • src/config/products.js — Correct. Version 3.3 is added with isLatest: true, the previous latest (3.2) is flipped to isLatest: false, and defaultVersion is bumped to 3.3. Exactly one version is marked latest, so the navbar/routing stays consistent.
  • sidebars/threatmanager/3.3.js — Correct. Uses an autogenerated sidebar (type: autogenerated, dirName: .), so no manual ID mapping to drift.
  • _category_.json files (26) — All category link: { type: doc, id: <id> } targets resolve to an existing .md in the same directory (e.g. administration/overview.md, install/upgrade/upgrade.md, administration/threats/threats.md). No autogenerated-sidebar build failures.
  • Internal doc links — All /docs/threatmanager/3.3/...md link targets exist; none point outside the new tree. With onBrokenLinks: 'throw' and onBrokenMarkdownLinks: 'throw', this is the main build risk and it is clean.
  • Anchors — The one cross-doc anchor link (threatresponse.md#preconfigured-actions) matches an existing ## Preconfigured Actions heading. onBrokenAnchors: 'throw' is satisfied.
  • Images — All /images/... references resolve on disk (including reuse of threatmanager/3.0, threatprevention/7.5, and activitymonitor/8.0 assets).

Minor (non-blocking) note:

  • Ten image references in docs/threatmanager/3.3/install/upgrade/upgrade3.3.md use a misspelled path segment intsall (e.g. /images/threatmanager/3.3/intsall/upgrade/setup-launcher.webp). This does not break the build only because the image files were committed under the matching misspelled folder static/images/threatmanager/3.3/intsall/upgrade/. Worth correcting the folder name and the references to install to avoid future breakage if someone "fixes" one side but not the other.

No scripts, GitHub Actions workflows, or KB-pipeline files were changed in this PR, and no security concerns (no secrets, eval, or injection surface) were introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants