Repository navigation
fix: support legacy firmware without prodname (SDK 0.3.5) - #31
Merged
Merged
Conversation
Preserve required calibration and malformed-name checks; prepare SDK 0.3.5 and verify HTTP-to-RDT startup with a nameless loopback device. Co-authored-by: Inigo Moreno <[email protected]>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A valid legacy sensor configuration without
<prodname>currently faults before StartRealtime, so Connect fails even when calibration scales and units are present. Treat only an absent product name as optional and display the genericATI Net F/Tlabel; preserve the sensor calibration and all present-name, required-calibration and XML validation. No public layout or ABI changes.Prepare SDK 0.3.5 as a stable compatibility patch. Credit Inigo Moreno's original compatibility fix in ros-netft #20, which remains untouched as requested.
Verification
prodnameerror, and the loopback client never starts RDT.git diff --check: passed. The locked formatter was applied to the affected C++ files.Downstream delivery
After the SDK release, synchronize the exact tagged source into CLI, Python, ROS and Viewer using their existing snapshot tools; preserve CLI's private adaptation and manifests. Release verified downstream patches so installed applications receive the fix. ROS #20 itself remains deferred and is not merged, closed or modified.
Hardware follow-up (2026-10-27): A Nano25 connected at 192.168.1.1 was then verified with the fixed SDK: firmware 2.2.56, no prodname in its real XML, 3,483 received records and 50 calibrated samples, zero invalid samples/status/errors/loss/reconnects. All 64 compared configuration fields were unchanged; no bias or configuration write was performed. The real Viewer 0.2.3 companion also completed Connect, 1,184 calibrated samples and Disconnect; its embedded SDK identity matched the released source, and all 64 configuration fields remained unchanged.