Skip to content

fix(auth): enable real OS keyring backends for secure-storage #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Finesssee merged 4 commits into from
Jul 24, 2026
Merged

fix(auth): enable real OS keyring backends for secure-storage #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df6f7b4
fix(auth): enable real OS keyring backends for secure-storage
Finesssee Jul 24, 2026
8a3f0a5
fix(ci): build and test secure-storage with platform keyring deps
Finesssee Jul 24, 2026
931f7ca
style: cargo fmt
Finesssee Jul 24, 2026
721533b
fix(keyring): treat missing-delete platform errors as success
Finesssee Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: Install Linux keyring build deps
if: runner.os == 'Linux'
run: sudo apt-get update && sudo apt-get install -y libdbus-1-dev pkg-config


- name: Install Rust
uses: dtolnay/rust-toolchain@stable
Expand All @@ -27,20 +31,28 @@ jobs:
uses: Swatinem/rust-cache@v2

- name: Run tests
run: cargo test --verbose
run: cargo test --verbose --features secure-storage

- name: Check formatting
run: cargo fmt --check

- name: Run clippy
run: cargo clippy -- -D warnings
run: cargo clippy --features secure-storage -- -D warnings

# Keep a default-features build green so crates.io installs without
# secure-storage still compile.
- name: Build without secure-storage
run: cargo build --verbose

build:
name: Build
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Install Linux keyring build deps
run: sudo apt-get update && sudo apt-get install -y libdbus-1-dev pkg-config


- name: Install Rust
uses: dtolnay/rust-toolchain@stable
Expand All @@ -49,4 +61,4 @@ jobs:
uses: Swatinem/rust-cache@v2

- name: Build release
run: cargo build --release
run: cargo build --release --features secure-storage
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ jobs:

steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- name: Install Linux keyring build deps
if: runner.os == 'Linux' && !matrix.use_cross
run: sudo apt-get update && sudo apt-get install -y libdbus-1-dev pkg-config


- name: Install Rust
uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
Expand All @@ -47,11 +51,11 @@ jobs:

- name: Build (cross)
if: matrix.use_cross
run: cross build --release --target ${{ matrix.target }}
run: cross build --release --features secure-storage --target ${{ matrix.target }}

- name: Build (native)
if: ${{ !matrix.use_cross }}
run: cargo build --release --target ${{ matrix.target }}
run: cargo build --release --features secure-storage --target ${{ matrix.target }}

- name: Package (Unix)
if: runner.os != 'Windows'
Expand Down
Loading
Loading