fix: retry on connection errors, covering server restarts and downtime - #41
Open
SansGuidon wants to merge 1 commit into
Open
fix: retry on connection errors, covering server restarts and downtime#41SansGuidon wants to merge 1 commit into
SansGuidon wants to merge 1 commit into
Conversation
AddRetryCondition replaces resty's built-in transport-error retry logic. The client gave up immediately on connection refused, DNS failures and timeouts regardless of --conn-retry-count and --conn-retry-wait. Fix: also retry when err != nil. Verified locally: stopped the server for 130s, ran yontrack project list against it. Retried 44 times and succeeded once the server came back up.
Author
|
@dcoraboeuf Rationale: this should allow to avoid breaking our workflows during ontrack upgrades/downtimes when using the cli. By default a downgrade causes a state that is not correctly managed in resty V2 (they fix it in V3 but it's still in RC) so this raw mitigation is hopefully acceptable til resty v3 is mature and adopted in ontrack CLI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddRetryCondition replaces resty's built-in transport-error retry logic. The client gave up immediately on connection refused, DNS failures and timeouts regardless of --conn-retry-count and --conn-retry-wait.
Fix: also retry when err != nil.
Verified locally: stopped the server for 130s, ran yontrack project list against it. Retried 44 times and succeeded once the server came back up.