Repository navigation
feat(pstack): render the poteto-mode status pill in theme colors - #28
Merged
Merged
Conversation
The pill carried two color emoji, which ignore the palette and render double-width beside the rest of the status line. It now uses only theme colors: a dot, a muted label, and a warning-colored state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
/poteto-modestatus pill showed two color emoji. They ignore the theme palette and render double-width, so they clash with the monochrome status line around them.What changed
●while a turn runs,○otherwise). The label is now mutedpotetoand a warning-coloredpinned, with no emoji.Scope
Blast Radius
Cosmetic. It touches one string in the
potetomodeextension.Verification
/poteto-mode onshowed○ 🥔 poteto: 👑 PINNEDbefore and○ poteto pinnedafter. The ANSI capture shows grey, muted and amber theme colors.bash omp-port/check-port.shprintscheck-port: PASS.