Repository navigation
feat(setup-pstack): validate and merge model aliases with apply-models.mjs - #26
Merged
Merged
Conversation
…s.mjs omp config set stores any string, so a bad selector or unknown alias failed only at spawn. The script checks every selector and effort against omp models --json before writing, touches only the three pstack aliases and their agent mappings, and is idempotent.
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
omp config setstores any string. A wrong model selector or an unknown@rolealias inmodelRolesortask.agentModelOverridesonly fails when a spawn runs.setup-pstackleft the check, the merge and the idempotence to the agent's prose.What changed
setup-pstack/scripts/apply-models.mjschecks every selector and effort againstomp models --json, then writes the threepstack_*aliases and their agent mappings. It supports--showand--dry-run.setup-pstack/SKILL.mdsteps 4 to 6 call the script. Steps 1 to 3, 7 and 8 and the ownership contract are unchanged.Scope
Tradeoffs
I did not take dsebban/skills'
apply-models.mjs. It validates@rolealiases against a fixed list of omp roles and rejects this port'spstack_*aliases.Blast Radius
It affects only
/skill:setup-pstack. A marketplace install has noscripts/folder until the next release.Verification
bun test plugins/pstack/skills/setup-pstack/scriptspasses, 11 tests against a stubomp. Each test fails when the behaviour it names breaks.PI_CODING_AGENT_DIRon omp 18.12.6, a real apply wrote both records, a rerun reported no change, and a nonexistent selector and an unsupported effort were refused withomp config getunchanged.check-port.shandtest-gate-mutations.shpass.