Repository navigation
Refuse test scripts ShellCheck cannot lint, in the test that writes them - #5
Merged
Merged
Conversation
CI lints every script a test writes. A zsh fixture (SC1071) and a #!bash fixture (SC2239) each failed that step after all tests had passed. Now TestScripts.write throws for a shebang ShellCheck cannot read, naming the line, before anything is written. Three tests. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Owner
Author
|
Review-Verdict: APPROVE review-pr (sonnet) LOW APPROVE: every existing TestScripts.write call passes the new rule; shells are a conservative subset of what ShellCheck supports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #4 (its base was the #3 branch, now squash-merged). TestScripts.write throws for a shebang ShellCheck cannot read (zsh, relative path), so the mistake fails locally instead of in CI after every test passed (twice on 2026-10-13). Three tests. Only TestScripts.swift and a new test file; no conflict with #3.
🤖 Generated with Claude Code