FIX: Preserve initial connection observers during ArcusClient initialization - #1114
Merged
Conversation
oliviarla
reviewed
Sep 10, 2026
oliviarla
left a comment
oliviarla
left a comment
Collaborator
There was a problem hiding this comment.
다음 PR로 아래 사항 수정하는 작업을 진행해야 할 것 같습니다.
- 지금은 옵저버 객체들의 메서드를 순차 호출하는 도중 예외가 발생하면, 이후의 옵저버 메서드가 호출되지 않는 형태이다.
- MemcachedConnection에서 connObservers 돌면서 옵저버 객체의 메서드 호출할 때, 예외 try-catch 하고 warning log 를 남긴다.
f1v3-dev
force-pushed
the
fix/observer
branch
from
September 10, 2026 03:22
a8c4a81 to
933ec77
Compare
oliviarla
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
CacheManager.initArcusClient()메서드에서 사용자가 설정한 초기 observer를 덮어쓰지 않도록 수정합니다.ArcusClient생성 시 초기 observer가 유지되는지 검증하는 테스트를 추가했습니다.