chore: upgrade Calcit to 0.13.77 - #34
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow YAML indentation is invalid (likely breaking CI parsing), and one new regression assertion is brittle due to referential equality on objects.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Upgrades the project to Calcit 0.13.77, migrates the project snapshot to calcit.cirru, and adds CI validation + regression tests to ensure the new Option-aware and pattern-matching behavior remains stable.
Changes:
- Bump Calcit/@calcit/procs (and related deps) to
0.13.77and updatedeps.cirru. - Switch build/compile entry to
calcit calcit.cirruand commit the canonicalcalcit.cirrusnapshot. - Add CI gates (format/type/quality checks) and JS regression tests for update/hydration/cursor behaviors.
File summaries
| File | Description |
|---|---|
| yarn.lock | Locks upgraded @calcit/procs and transitive dependency versions. |
| package.json | Updates compile/build scripts and pins @calcit/procs to 0.13.77. |
| deps.cirru | Updates Calcit version and Calcit dependency set. |
| calcit.cirru | Migrated canonical snapshot; introduces Option-aware access and match-based updater logic. |
| config/calcit-quality.cirru | Adds a quality baseline used by CI. |
| scripts/upgrade.test.mjs | Adds regression tests for store updates, hydration round-trips, and cursor/state updates. |
| .github/workflows/upload.yaml | Updates CI to install/validate Calcit + caps, run formatting/quality gates, and run JS regression tests. |
| .gitignore | Ignores .calcit/ directory. |
Review details
- Files reviewed: 6/8 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+30
to
+32
| - name: Install dependencies | ||
| run: caps --strict --ci && yarn install --immutable | ||
|
|
Comment on lines
+13
to
+15
| assert.equal(read(updated, tags.content), 'hello'); | ||
| assert.equal(read(store, tags.content), ''); | ||
| assert.equal(read(updated, tags.states), read(store, tags.states)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
Upgrade Calcit/@calcit/procs 0.12.14 to 0.13.77; migrate compact.cirru to canonical calcit.cirru and set the browser JS entry. Fix all 16 preprocessing warnings with Option-aware Map and environment access, typed RespoEvent input and string validation of browser storage. Replace tag-match with match while preserving persisted Map format.
Gates and tests
Add CI format/type/quality checks and three JS regression tests for content updates, cursor updates and persistence round-trips. PRs no longer deploy. The per-definition quality baseline records existing debt (14 schema Dynamic and 2 code Nil); it is not a claim of fully strict typing.
Validation with published dependencies
markdown 0.4.32 is now released; no pending upstream dependency blocker. Passed caps --strict --ci, immutable Yarn install, caps verify --toolchain, default init/reload check, JS codegen, all three regression tests, quality baseline and Node 24 / Vite 8.0.16 production build. No local dependency overrides.
Read calcit docs read upgrade in this project. Ready for review; maintainer merges.